(in-package "SPECIALIZABLE")
(defclass extended-specializer (sb-mop:specializer)
+ ;; FIXME: this doesn't actually do quite what I wanted.
((direct-methods-table :allocation :class
:initform nil :accessor direct-methods-table)))
;;; gf
;;; args))))
-;;; FIXME: this (and add/remove-direct-method) don't actually work
-;;; together, because two distinct calls to make-extended-specializer
-;;; return two distinct specializer objects. We need either to make
-;;; the extended specializers be interned, or to have them be
-;;; arbitrarily ephemeral but adjust specializer-direct-methods (and
-;;; implement specializer-direct-generic-functions) accordingly.
(defun make-extended-specializer (sname)
(destructuring-bind (kind &rest args) sname
(apply (or (get kind 'extended-specializer-parser)
;;; FIXME: in some kind of order, the discriminating function needs to handle:
;;; - argument count checking;
-;;; - keyword argument validity;
+;;; - DONE (in effective method) keyword argument validity;
;;; - DONE flushing the emf cache on method addition/removal
;;; - DONE (sort of, using wrappers/g-e-h-k) flushing the cache on class redefinition;
;;; - cache thread-safety.
(compute-applicable-methods-using-generalizers gf generalizers)
(if definitivep
(let* ((emfun
- (compute-effective-method-function gf applicable-methods))
+ (compute-effective-method-function gf applicable-methods))
(keys (mapcar (lambda (x) (generalizer-equal-hash-key gf x)) generalizers)))
(setf (gethash keys (emf-table gf)) emfun)
(sb-pcl::invoke-emf emfun args))
- (sb-pcl::invoke-emf (compute-effective-method-function
+ (sb-pcl::invoke-emf (compute-effective-method-function
gf (sb-mop:compute-applicable-methods gf args))
args))))
(defun compute-effective-method-function (gf methods)
(let* ((mc (sb-mop:generic-function-method-combination gf))
+ (sb-pcl::*applicable-methods* methods)
(em (sb-mop:compute-effective-method gf mc methods)))
(sb-pcl::make-effective-method-function gf em)))